`erase()` calls `find()` to get the index of the element to remove, if any. https://github.com/godotengine/godot/blob/c2151e18135817c9f926a5a00341016ac77301d4/core/local_vector.h#L77-L81 `find()` returns a signed integer. In particular, it returns -1 if no element is found. Since `erase()` converts this to an unsigned type, the wrong element may be erroneously removed from the vector. Other ways to fix this would involve changing function signatures, so this seemed to be the least disruptive change. Fixes #38884
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
bind | Loading commit data... | |
crypto | Loading commit data... | |
debugger | Loading commit data... | |
input | Loading commit data... | |
io | Loading commit data... | |
math | Loading commit data... | |
os | Loading commit data... | |
SCsub | Loading commit data... | |
array.cpp | Loading commit data... | |
array.h | Loading commit data... | |
callable.cpp | Loading commit data... | |
callable.h | Loading commit data... | |
callable_method_pointer.cpp | Loading commit data... | |
callable_method_pointer.h | Loading commit data... | |
class_db.cpp | Loading commit data... | |
class_db.h | Loading commit data... | |
color.cpp | Loading commit data... | |
color.h | Loading commit data... | |
color_names.inc | Loading commit data... | |
command_queue_mt.cpp | Loading commit data... | |
command_queue_mt.h | Loading commit data... | |
compressed_translation.cpp | Loading commit data... | |
compressed_translation.h | Loading commit data... | |
container_type_validate.h | Loading commit data... | |
core_builders.py | Loading commit data... | |
core_string_names.cpp | Loading commit data... | |
core_string_names.h | Loading commit data... | |
cowdata.h | Loading commit data... | |
dictionary.cpp | Loading commit data... | |
dictionary.h | Loading commit data... | |
engine.cpp | Loading commit data... | |
engine.h | Loading commit data... | |
error_list.h | Loading commit data... | |
error_macros.cpp | Loading commit data... | |
error_macros.h | Loading commit data... | |
func_ref.cpp | Loading commit data... | |
func_ref.h | Loading commit data... | |
global_constants.cpp | Loading commit data... | |
global_constants.h | Loading commit data... | |
hash_map.h | Loading commit data... | |
hashfuncs.h | Loading commit data... | |
image.cpp | Loading commit data... | |
image.h | Loading commit data... | |
int_types.h | Loading commit data... | |
list.h | Loading commit data... | |
local_vector.h | Loading commit data... | |
make_binders.py | Loading commit data... | |
map.h | Loading commit data... | |
message_queue.cpp | Loading commit data... | |
message_queue.h | Loading commit data... | |
method_bind.cpp | Loading commit data... | |
method_bind.h | Loading commit data... | |
method_ptrcall.h | Loading commit data... | |
node_path.cpp | Loading commit data... | |
node_path.h | Loading commit data... | |
oa_hash_map.h | Loading commit data... | |
object.cpp | Loading commit data... | |
object.h | Loading commit data... | |
object_id.h | Loading commit data... | |
ordered_hash_map.h | Loading commit data... | |
packed_data_container.cpp | Loading commit data... | |
packed_data_container.h | Loading commit data... | |
pair.h | Loading commit data... | |
pool_allocator.cpp | Loading commit data... | |
pool_allocator.h | Loading commit data... | |
print_string.cpp | Loading commit data... | |
print_string.h | Loading commit data... | |
project_settings.cpp | Loading commit data... | |
project_settings.h | Loading commit data... | |
reference.cpp | Loading commit data... | |
reference.h | Loading commit data... | |
register_core_types.cpp | Loading commit data... | |
register_core_types.h | Loading commit data... | |
resource.cpp | Loading commit data... | |
resource.h | Loading commit data... | |
rid.h | Loading commit data... | |
rid_owner.cpp | Loading commit data... | |
rid_owner.h | Loading commit data... | |
ring_buffer.h | Loading commit data... | |
safe_refcount.cpp | Loading commit data... | |
safe_refcount.h | Loading commit data... | |
script_language.cpp | Loading commit data... | |
script_language.h | Loading commit data... | |
self_list.h | Loading commit data... | |
set.h | Loading commit data... | |
simple_type.h | Loading commit data... | |
sort_array.h | Loading commit data... | |
spin_lock.h | Loading commit data... | |
string_buffer.h | Loading commit data... | |
string_builder.cpp | Loading commit data... | |
string_builder.h | Loading commit data... | |
string_name.cpp | Loading commit data... | |
string_name.h | Loading commit data... | |
thread_work_pool.cpp | Loading commit data... | |
thread_work_pool.h | Loading commit data... | |
translation.cpp | Loading commit data... | |
translation.h | Loading commit data... | |
type_info.h | Loading commit data... | |
typed_array.h | Loading commit data... | |
typedefs.h | Loading commit data... | |
ucaps.h | Loading commit data... | |
undo_redo.cpp | Loading commit data... | |
undo_redo.h | Loading commit data... | |
ustring.cpp | Loading commit data... | |
ustring.h | Loading commit data... | |
variant.cpp | Loading commit data... | |
variant.h | Loading commit data... | |
variant_call.cpp | Loading commit data... | |
variant_op.cpp | Loading commit data... | |
variant_parser.cpp | Loading commit data... | |
variant_parser.h | Loading commit data... | |
vector.h | Loading commit data... | |
version.h | Loading commit data... | |
vmap.h | Loading commit data... | |
vset.h | Loading commit data... |