Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
godot
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
community
godot
Commits
fe069661
Unverified
Commit
fe069661
authored
Dec 07, 2019
by
Hugo Locurcio
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make some arguments in PCKPacker methods optional
Those arguments aren't required for most common use cases, so making them optional should help with code readability.
parent
ff58030e
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
7 deletions
+7
-7
pck_packer.cpp
core/io/pck_packer.cpp
+2
-2
pck_packer.h
core/io/pck_packer.h
+1
-1
PCKPacker.xml
doc/classes/PCKPacker.xml
+4
-4
No files found.
core/io/pck_packer.cpp
View file @
fe069661
...
...
@@ -55,9 +55,9 @@ static void _pad(FileAccess *p_file, int p_bytes) {
void
PCKPacker
::
_bind_methods
()
{
ClassDB
::
bind_method
(
D_METHOD
(
"pck_start"
,
"pck_name"
,
"alignment"
),
&
PCKPacker
::
pck_start
);
ClassDB
::
bind_method
(
D_METHOD
(
"pck_start"
,
"pck_name"
,
"alignment"
),
&
PCKPacker
::
pck_start
,
DEFVAL
(
0
)
);
ClassDB
::
bind_method
(
D_METHOD
(
"add_file"
,
"pck_path"
,
"source_path"
),
&
PCKPacker
::
add_file
);
ClassDB
::
bind_method
(
D_METHOD
(
"flush"
,
"verbose"
),
&
PCKPacker
::
flush
);
ClassDB
::
bind_method
(
D_METHOD
(
"flush"
,
"verbose"
),
&
PCKPacker
::
flush
,
DEFVAL
(
false
)
);
};
Error
PCKPacker
::
pck_start
(
const
String
&
p_file
,
int
p_alignment
)
{
...
...
core/io/pck_packer.h
View file @
fe069661
...
...
@@ -54,7 +54,7 @@ class PCKPacker : public Reference {
Vector
<
File
>
files
;
public
:
Error
pck_start
(
const
String
&
p_file
,
int
p_alignment
);
Error
pck_start
(
const
String
&
p_file
,
int
p_alignment
=
0
);
Error
add_file
(
const
String
&
p_file
,
const
String
&
p_src
);
Error
flush
(
bool
p_verbose
=
false
);
...
...
doc/classes/PCKPacker.xml
View file @
fe069661
...
...
@@ -6,9 +6,9 @@
The [PCKPacker] is used to create packages in application runtime.
[codeblock]
var packer = PCKPacker.new()
packer.pck_start("test.pck"
, 0
)
packer.pck_start("test.pck")
packer.add_file("res://text.txt", "text.txt")
packer.flush(
false
)
packer.flush()
[/codeblock]
The above [PCKPacker] creates package [b]test.pck[/b], then adds a file named [b]text.txt[/b] in the root of the package.
</description>
...
...
@@ -29,7 +29,7 @@
<method
name=
"flush"
>
<return
type=
"int"
enum=
"Error"
>
</return>
<argument
index=
"0"
name=
"verbose"
type=
"bool"
>
<argument
index=
"0"
name=
"verbose"
type=
"bool"
default=
"false"
>
</argument>
<description>
</description>
...
...
@@ -39,7 +39,7 @@
</return>
<argument
index=
"0"
name=
"pck_name"
type=
"String"
>
</argument>
<argument
index=
"1"
name=
"alignment"
type=
"int"
>
<argument
index=
"1"
name=
"alignment"
type=
"int"
default=
"0"
>
</argument>
<description>
</description>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment