Merge pull request #25680 from Chaosus/random_fix

Fix random generation, to not always retrieve 0 after seed()

Merge pull request #25680 from Chaosus/random_fix
f6fcbcfe · Rémi Verschelde · GitHub · 9402d2f9 · f946b28f · f6fcbcfe
Unverified Commit f6fcbcfe authored Feb 16, 2019 by Rémi Verschelde Committed by GitHub Feb 16, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

random_pcg.h core/math/random_pcg.h +4 -1

No files found.
--- a/core/math/random_pcg.h
+++ b/core/math/random_pcg.h
@@ -45,7 +45,10 @@ public:

 	RandomPCG(uint64_t seed = DEFAULT_SEED, uint64_t inc = PCG_DEFAULT_INC_64);

-	_FORCE_INLINE_ void seed(uint64_t seed) { pcg.state = seed; }
+	_FORCE_INLINE_ void seed(uint64_t seed) {
+		pcg.state = seed;
+		pcg32_random_r(&pcg); // Force changing internal state to avoid initial 0
+	}
 	_FORCE_INLINE_ uint64_t get_seed() { return pcg.state; }

 	void randomize();