Merge pull request #39201 from Calinou/midi-input-unsupported-error

Print errors when calling MIDI input methods on unsupported platforms

Merge pull request #39201 from Calinou/midi-input-unsupported-error
9043605a · Rémi Verschelde · GitHub · cec49bd1 · 9c0d2147 · 9043605a
Unverified Commit 9043605a authored Jun 03, 2020 by Rémi Verschelde Committed by GitHub Jun 03, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

os.cpp core/os/os.cpp +5 -1

No files found.
--- a/core/os/os.cpp
+++ b/core/os/os.cpp
@@ -457,18 +457,22 @@ PackedStringArray OS::get_connected_midi_inputs() {
 	}

 	PackedStringArray list;
-	return list;
+	ERR_FAIL_V_MSG(list, vformat("MIDI input isn't supported on %s.", OS::get_singleton()->get_name()));
 }

 void OS::open_midi_inputs() {
 	if (MIDIDriver::get_singleton()) {
 		MIDIDriver::get_singleton()->open();
+	} else {
+		ERR_PRINT(vformat("MIDI input isn't supported on %s.", OS::get_singleton()->get_name()));
 	}
 }

 void OS::close_midi_inputs() {
 	if (MIDIDriver::get_singleton()) {
 		MIDIDriver::get_singleton()->close();
+	} else {
+		ERR_PRINT(vformat("MIDI input isn't supported on %s.", OS::get_singleton()->get_name()));
 	}
 }