Merge pull request #39275 from ThakeeNathees/shadowed-warning-for-loop-counter

Added shadowed var warning for `for` loop counter

Merge pull request #39275 from ThakeeNathees/shadowed-warning-for-loop-counter
697897cc · Rémi Verschelde · GitHub · 78d09a41 · 54835a53 · 697897cc
Unverified Commit 697897cc authored Jun 16, 2020 by Rémi Verschelde Committed by GitHub Jun 16, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

gdscript_parser.cpp modules/gdscript/gdscript_parser.cpp +7 -0

No files found.
--- a/modules/gdscript/gdscript_parser.cpp
+++ b/modules/gdscript/gdscript_parser.cpp
@@ -3180,6 +3180,13 @@ void GDScriptParser::_parse_block(BlockNode *p_block, bool p_static) {

 				IdentifierNode *id = alloc_node<IdentifierNode>();
 				id->name = tokenizer->get_token_identifier();
+#ifdef DEBUG_ENABLED
+				for (int j = 0; j < current_class->variables.size(); j++) {
+					if (current_class->variables[j].identifier == id->name) {
+						_add_warning(GDScriptWarning::SHADOWED_VARIABLE, id->line, id->name, itos(current_class->variables[j].line));
+					}
+				}
+#endif // DEBUG_ENABLED

 				BlockNode *check_block = p_block;
 				while (check_block) {