Fix crashing of VisualScript due to...

Attempting to move the function node to another function whose data connection is a dependency of the node the specific node being moved to a different function during changes to sequence connections. By skipping, if the from_node is a function_node during the data connection dependencies scan. Should fix #37991

Fix crashing of VisualScript due to...
5c486315 · Swarnim Arun · GitHub · bfac9b35 · 5c486315
Unverified Commit 5c486315 authored May 25, 2020 by Swarnim Arun Committed by GitHub May 25, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

visual_script_editor.cpp modules/visual_script/visual_script_editor.cpp +6 -0

No files found.
--- a/modules/visual_script/visual_script_editor.cpp
+++ b/modules/visual_script/visual_script_editor.cpp
@@ -3216,6 +3216,7 @@ void VisualScriptEditor::_move_nodes_with_rescan(const StringName &p_func_from, 
 	{
 		List<VisualScript::DataConnection> data_connections;
 		script->get_data_connection_list(p_func_from, &data_connections);
+		int func_from_node_id = script->get_function_node_id(p_func_from);

 		HashMap<int, Map<int, Pair<int, int>>> connections;

@@ -3225,6 +3226,11 @@ void VisualScriptEditor::_move_nodes_with_rescan(const StringName &p_func_from, 
 			int out_p = E->get().from_port;
 			int in_p = E->get().to_port;

+			// skip if the from_node is a function node
+			if (from == func_from_node_id) {
+				continue;
+			}
+
 			if (!connections.has(to)) {
 				connections.set(to, Map<int, Pair<int, int>>());
 			}