Merge pull request #36512 from AndreaCatania/AndreaCatania-patch-2

Fixed remove region method.

Merge pull request #36512 from AndreaCatania/AndreaCatania-patch-2
2ead4393 · Rémi Verschelde · GitHub · 0e724fc8 · c16711b1 · 2ead4393
Unverified Commit 2ead4393 authored Feb 25, 2020 by Rémi Verschelde Committed by GitHub Feb 25, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

nav_map.cpp modules/gdnavigation/nav_map.cpp +5 -2

No files found.
--- a/modules/gdnavigation/nav_map.cpp
+++ b/modules/gdnavigation/nav_map.cpp
@@ -545,8 +545,11 @@ void NavMap::add_region(NavRegion *p_region) {
 }

 void NavMap::remove_region(NavRegion *p_region) {
-	regions.push_back(p_region);
-	regenerate_links = true;
+	std::vector<NavRegion *>::iterator it = std::find(regions.begin(), regions.end(), p_region);
+	if (it != regions.end()) {
+		regions.erase(it);
+		regenerate_links = true;
+	}
 }

 bool NavMap::has_agent(RvoAgent *agent) const {