Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
godot
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
community
godot
Commits
74ab8be5
Unverified
Commit
74ab8be5
authored
Oct 11, 2019
by
Rémi Verschelde
Committed by
GitHub
Oct 11, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #32752 from m4gr3d/clean_metadata_parsing_fix
Cleanup fix for the meta-data parsing crashing bug.
parents
3cc94b2c
d0f8ef76
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
12 deletions
+4
-12
export.cpp
platform/android/export/export.cpp
+4
-12
No files found.
platform/android/export/export.cpp
View file @
74ab8be5
...
...
@@ -766,17 +766,9 @@ class EditorExportPlatformAndroid : public EditorExportPlatform {
uint32_t
attr_value
=
decode_uint32
(
&
p_manifest
[
iofs
+
8
]);
uint32_t
attr_resid
=
decode_uint32
(
&
p_manifest
[
iofs
+
16
]);
String
value
;
if
(
attr_value
!=
0xFFFFFFFF
)
value
=
string_table
[
attr_value
];
else
value
=
"Res #"
+
itos
(
attr_resid
);
const
String
value
=
(
attr_value
!=
0xFFFFFFFF
)
?
string_table
[
attr_value
]
:
"Res #"
+
itos
(
attr_resid
);
String
attrname
=
string_table
[
attr_name
];
String
nspace
;
if
(
attr_nspace
!=
0xFFFFFFFF
)
nspace
=
string_table
[
attr_nspace
];
else
nspace
=
""
;
const
String
nspace
=
(
attr_nspace
!=
0xFFFFFFFF
)
?
string_table
[
attr_nspace
]
:
""
;
//replace project information
if
(
tname
==
"manifest"
&&
attrname
==
"package"
)
{
...
...
@@ -830,14 +822,14 @@ class EditorExportPlatformAndroid : public EditorExportPlatform {
// FIXME: `attr_value != 0xFFFFFFFF` below added as a stopgap measure for GH-32553,
// but the issue should be debugged further and properly addressed.
if
(
tname
==
"meta-data"
&&
attrname
==
"name"
&&
attr_value
!=
0xFFFFFFFF
&&
string_table
[
attr_value
]
==
"xr_mode_metadata_name"
)
{
if
(
tname
==
"meta-data"
&&
attrname
==
"name"
&&
value
==
"xr_mode_metadata_name"
)
{
// Update the meta-data 'android:name' attribute based on the selected XR mode.
if
(
xr_mode_index
==
1
/* XRMode.OVR */
)
{
string_table
.
write
[
attr_value
]
=
"com.samsung.android.vr.application.mode"
;
}
}
if
(
tname
==
"meta-data"
&&
attrname
==
"value"
&&
attr_value
!=
0xFFFFFFFF
&&
string_table
[
attr_value
]
==
"xr_mode_metadata_value"
)
{
if
(
tname
==
"meta-data"
&&
attrname
==
"value"
&&
value
==
"xr_mode_metadata_value"
)
{
// Update the meta-data 'android:value' attribute based on the selected XR mode.
if
(
xr_mode_index
==
1
/* XRMode.OVR */
)
{
string_table
.
write
[
attr_value
]
=
"vr_only"
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment